Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • World
  • Users
  • Groups
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Brand Logo

agnos.is Forums

  1. Home
  2. Technology
  3. GitHub - LadybirdBrowser/ladybird: Truly independent web browser

GitHub - LadybirdBrowser/ladybird: Truly independent web browser

Scheduled Pinned Locked Moved Technology
195 Posts 93 Posters 1.9k Views
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • gon@lemm.eeG [email protected]

    Sigh, you do have a point.

    Maybe this was by a different reviewer, idk.

    It was. Some other member of SerenityOS, not the person behind Ladybird (awesomekling).

    blog author should be more accurate (see above)

    That's fair. I'll say though, the blog post is dated from 1 day after the PR was actually merged. It's not unreasonable to think that, when they wrote it, it really hadn't been merged and they only saw the initial denial citing the policy.

    He may be. Idk.

    Yeah, I was just trying to say that that wasn't the point of my rant. I get it I get it.

    S This user is from outside of this forum
    S This user is from outside of this forum
    [email protected]
    wrote on last edited by
    #84

    It’s not unreasonable to think that, when they wrote it, it really hadn’t been merged and they only saw the initial denial citing the policy.

    That never happened on this PR. The only human reply before the merge (aside from the submitter) was this:

    Please fix the commit messages (see BuggieBot's comment); and maybe this can go in one commit? Doesn't really need to be 5 separate ones.

    And this is BuggieBot's comment:

    Hello!

    One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
    Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

    It's a completely different.

    This, plus the tone of the blog post looks like they were on a crusade instead of trying to accurately portray events.

    Sorry to beat a dead horse here, my point is that we all need to be careful jumping to conclusions, especially in FOSS where discussion almost exclusively happens asynchronously in text and with people with different backgrounds. Pretty much everyone involved failed at that.

    gon@lemm.eeG 1 Reply Last reply
    0
    • S [email protected]

      It’s not unreasonable to think that, when they wrote it, it really hadn’t been merged and they only saw the initial denial citing the policy.

      That never happened on this PR. The only human reply before the merge (aside from the submitter) was this:

      Please fix the commit messages (see BuggieBot's comment); and maybe this can go in one commit? Doesn't really need to be 5 separate ones.

      And this is BuggieBot's comment:

      Hello!

      One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
      Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

      It's a completely different.

      This, plus the tone of the blog post looks like they were on a crusade instead of trying to accurately portray events.

      Sorry to beat a dead horse here, my point is that we all need to be careful jumping to conclusions, especially in FOSS where discussion almost exclusively happens asynchronously in text and with people with different backgrounds. Pretty much everyone involved failed at that.

      gon@lemm.eeG This user is from outside of this forum
      gon@lemm.eeG This user is from outside of this forum
      [email protected]
      wrote on last edited by
      #85

      And this is BuggieBot’s comment:

      Yeah I was referencing that comment.

      Sequence of events:

      1. PR trying to change pronouns.
      2. Automated response citing policy.
      3. Author takes note of it for blog post.
      4. PR fixed and merged.
      5. Blog post published.

      Precocious, certainly, and I agree it was misguided. The blog post was indeed emotionally motivated, that's more than clear.

      Sorry to beat a dead horse here

      It's alright. I think these discussions need to be had.

      S 1 Reply Last reply
      0
      • gon@lemm.eeG [email protected]

        And this is BuggieBot’s comment:

        Yeah I was referencing that comment.

        Sequence of events:

        1. PR trying to change pronouns.
        2. Automated response citing policy.
        3. Author takes note of it for blog post.
        4. PR fixed and merged.
        5. Blog post published.

        Precocious, certainly, and I agree it was misguided. The blog post was indeed emotionally motivated, that's more than clear.

        Sorry to beat a dead horse here

        It's alright. I think these discussions need to be had.

        S This user is from outside of this forum
        S This user is from outside of this forum
        [email protected]
        wrote on last edited by
        #86

        Right, but the policy was commit hygiene (lots of small commits), which has nothing to do with the "no politics" policy. It's right there in the comment, and the suggestion is to squash the commits into one.

        It’s alright. I think these discussions need to be had.

        Agreed. And unfortunately, I felt it necessary to be really wordy to not come off as supporting intolerance in any way, while still arguing that I would've done the same (reject 1-line cosmetic PRs).

        This is some kind of correlary to Poe's Law, or perhaps Godwin's Law.

        gon@lemm.eeG 1 Reply Last reply
        0
        • S [email protected]

          Right, but the policy was commit hygiene (lots of small commits), which has nothing to do with the "no politics" policy. It's right there in the comment, and the suggestion is to squash the commits into one.

          It’s alright. I think these discussions need to be had.

          Agreed. And unfortunately, I felt it necessary to be really wordy to not come off as supporting intolerance in any way, while still arguing that I would've done the same (reject 1-line cosmetic PRs).

          This is some kind of correlary to Poe's Law, or perhaps Godwin's Law.

          gon@lemm.eeG This user is from outside of this forum
          gon@lemm.eeG This user is from outside of this forum
          [email protected]
          wrote on last edited by
          #87

          Right, but the policy was commit hygiene (lots of small commits), which has nothing to do with the “no politics” policy. It’s right there in the comment, and the suggestion is to squash the commits into one.

          Suspiciously close to what Hitler would say... /s

          S 1 Reply Last reply
          0
          • ambitiousslab@lemmy.mlA [email protected]

            I donate to Ladybird and Servo, and I hope they succeed. We need serious competition and a check on Mozilla (not to mention Chrome and Safari).

            That said, I'm sad that neither Ladybird or Servo are licensed under strong copyleft licenses. We need user-oriented browsers now more than ever, and strong copyleft enables that. I worry that, even if these engines are successful, they will be co-opted by proprietary browsers and eventually superseded by them.

            This happened before - both Chrome and Safari ultimately derive from KHTML, Konqueror's browser engine. If KHTML had been licnesed under the GPL instead of the LGPL, Chrome and Safari may have been free software today (or at the very least, it would have been much more difficult for Apple and Google to get started).

            That said, I wish Ladybird the best. There donation = no influence policy is excellent, and I really, really hope they can stick to it in the long term.

            zangoose@lemmy.worldZ This user is from outside of this forum
            zangoose@lemmy.worldZ This user is from outside of this forum
            [email protected]
            wrote on last edited by
            #88

            Isn't servo mostly a Mozilla-led project? I thought servo would probably just replace gecko as the engine firefox used if it ends up succeeding

            S L 2 Replies Last reply
            0
            • gon@lemm.eeG [email protected]

              Right, but the policy was commit hygiene (lots of small commits), which has nothing to do with the “no politics” policy. It’s right there in the comment, and the suggestion is to squash the commits into one.

              Suspiciously close to what Hitler would say... /s

              S This user is from outside of this forum
              S This user is from outside of this forum
              [email protected]
              wrote on last edited by
              #89

              Lol, got me there.

              Hitler would probably be a formatting Nazi too. Can't have that <insert slur> extra whitespace.

              1 Reply Last reply
              0
              • zangoose@lemmy.worldZ [email protected]

                Isn't servo mostly a Mozilla-led project? I thought servo would probably just replace gecko as the engine firefox used if it ends up succeeding

                S This user is from outside of this forum
                S This user is from outside of this forum
                [email protected]
                wrote on last edited by
                #90

                Iirc it started its life that way but Mozilla abandoned it and the community picked it up

                1 Reply Last reply
                0
                • S [email protected]

                  True, but that only applies if it's misleading. For example:

                  // pythagoran theorem 
                  distance = abs(p2.x - p1.x) + abs(p2.y - p1.y); 
                  

                  Fixing that makes sense because it's wrong and misleading (it's actually Manhattan distance), and a quick glace is insufficient to tell the difference.

                  But fixing a typo or something that wouldn't be confusing is just noise and should only be fixed with other changes. For example, I intentionally misspelled Pythagorean in my comment above, fixing that to be the right spelling would be a useless change, even if the distance formula used the hypotenuse. It wouldn't be an unreasonable policy to reject PRs that only fix spelling or similar to reduce noise for the maintainers.

                  S This user is from outside of this forum
                  S This user is from outside of this forum
                  [email protected]
                  wrote on last edited by
                  #91

                  Yep, I understand but disagree. Maybe it comes from working with so many ESL coders, but I'll happily accept typo corrections because it's not always obvious what words should be if you're not steeped in the culture.

                  S 1 Reply Last reply
                  0
                  • S [email protected]

                    Yep, I understand but disagree. Maybe it comes from working with so many ESL coders, but I'll happily accept typo corrections because it's not always obvious what words should be if you're not steeped in the culture.

                    S This user is from outside of this forum
                    S This user is from outside of this forum
                    [email protected]
                    wrote on last edited by
                    #92

                    It really depends on the project.

                    If you're a larger project, you can see a ton of these from people hoping to land a commit to put "contributor to X" on a resume somewhere. Those add up and are really distracting and possibly automated. They waste everyone's time, especially if they spawn a bunch of conversion like this did.

                    If you're a smaller project, it doesn't matter as much. I work with ESL coders too, so I get it (1/4 of my office is ESL immigrants, and ~2/3 of the broader team is ESL). I fix comments all the time, I just include them with other changes.

                    So it depends. But in general, a high profile project should reject this noise to discourage this behavior.

                    P 1 Reply Last reply
                    0
                    • M [email protected]
                      This post did not contain any content.
                      troed@fedia.ioT This user is from outside of this forum
                      troed@fedia.ioT This user is from outside of this forum
                      [email protected]
                      wrote on last edited by
                      #93

                      Alright, read up on it a bit more. Sadly the language choices (C++ now, maybe Swift later) rubs me the wrong way for something that needs to be incredibly secure against attacks. I really really support additional browser engines, but likely not this one.

                      Thus I think Servo is a better choice for those looking to contribute. IMHO.

                      L 1 Reply Last reply
                      0
                      • S [email protected]

                        Why always discord.... Why!!!!

                        P This user is from outside of this forum
                        P This user is from outside of this forum
                        [email protected]
                        wrote on last edited by
                        #94

                        because a turn key platform they don’t have to self host and maintain frees them up to do the work.

                        1 Reply Last reply
                        0
                        • S [email protected]

                          They absolutely do. A lot of distros package Firefox or Chromium or something as the default, but those browsers are default for their respective DEs.

                          H This user is from outside of this forum
                          H This user is from outside of this forum
                          [email protected]
                          wrote on last edited by
                          #95

                          Konqueror is more or less dead as a browser. I don't even think kwebkitpart is maintained anymore since QtWebkit was abandoned with Qt6.

                          S 1 Reply Last reply
                          0
                          • C [email protected]

                            TBH, it is very difficult to me differentiating between the different flavors of authoritarians.

                            P This user is from outside of this forum
                            P This user is from outside of this forum
                            [email protected]
                            wrote on last edited by
                            #96

                            Fascism, just like Communism or even a Dictatorships are not inherently bad.

                            We as humans key in on the oppressive authoritarianism of them as the evil in the system.

                            That’s why I’d recommend you lump them all together as “oppressive authoritarianism” until one of them proves us otherwise, and not to need to find the nuances between them to prove they’re bad.

                            P P 2 Replies Last reply
                            0
                            • C [email protected]

                              TBH, it is very difficult to me differentiating between the different flavors of authoritarians.

                              N This user is from outside of this forum
                              N This user is from outside of this forum
                              [email protected]
                              wrote on last edited by
                              #97

                              There's basically ideologues versus hateful people versus indifferent sociopaths (overlap is common)

                              I consider political ideologues and "technocrats" and extremely pedantic rule-following bureaucrats to be different flavors of ideologues (has a specific worldview they try to enforce / uphold)

                              1 Reply Last reply
                              0
                              • H [email protected]

                                Konqueror is more or less dead as a browser. I don't even think kwebkitpart is maintained anymore since QtWebkit was abandoned with Qt6.

                                S This user is from outside of this forum
                                S This user is from outside of this forum
                                [email protected]
                                wrote on last edited by
                                #98

                                It had a release this month, that doesn't sound dead...

                                H 1 Reply Last reply
                                0
                                • P [email protected]

                                  Fascism, just like Communism or even a Dictatorships are not inherently bad.

                                  We as humans key in on the oppressive authoritarianism of them as the evil in the system.

                                  That’s why I’d recommend you lump them all together as “oppressive authoritarianism” until one of them proves us otherwise, and not to need to find the nuances between them to prove they’re bad.

                                  P This user is from outside of this forum
                                  P This user is from outside of this forum
                                  [email protected]
                                  wrote on last edited by
                                  #99

                                  Fascism, just like Communism or even a Dictatorships are not inherently bad

                                  No offense but what the fuck are you even saying

                                  Fascism is absolutely inherently bad, there is no removal of its evil, oppressive, and authoritarian traits after which anything is left.

                                  eldritch@lemmy.worldE 1 Reply Last reply
                                  0
                                  • S [email protected]

                                    Existence? Because somebody used a wrong pronoun?

                                    P This user is from outside of this forum
                                    P This user is from outside of this forum
                                    [email protected]
                                    wrote on last edited by
                                    #100

                                    You're right, words are meaningless and language has no bearing on society at large. after all, fuiebt eidiowb rhe efifo quifopim.

                                    S S 2 Replies Last reply
                                    0
                                    • S [email protected]

                                      It really depends on the project.

                                      If you're a larger project, you can see a ton of these from people hoping to land a commit to put "contributor to X" on a resume somewhere. Those add up and are really distracting and possibly automated. They waste everyone's time, especially if they spawn a bunch of conversion like this did.

                                      If you're a smaller project, it doesn't matter as much. I work with ESL coders too, so I get it (1/4 of my office is ESL immigrants, and ~2/3 of the broader team is ESL). I fix comments all the time, I just include them with other changes.

                                      So it depends. But in general, a high profile project should reject this noise to discourage this behavior.

                                      P This user is from outside of this forum
                                      P This user is from outside of this forum
                                      [email protected]
                                      wrote on last edited by
                                      #101

                                      In theory that's fair reasoning. Unfortunately the dev made it clear that his reasoning was based on politics

                                      S 1 Reply Last reply
                                      0
                                      • H [email protected]

                                        I see zero reason to out the "transphobic" label on the dev.

                                        Think and read before labelling people.

                                        E This user is from outside of this forum
                                        E This user is from outside of this forum
                                        [email protected]
                                        wrote on last edited by
                                        #102

                                        Calling pronouns political is a straight up dog whistle

                                        a_wild_mimic_appears@lemmy.dbzer0.comA 1 Reply Last reply
                                        0
                                        • S [email protected]

                                          Someone else posted a writeup about it.

                                          It wasn't in documentation, but a code comment. No user would see this.

                                          One part was a rejected change on the README, which was trying to remove this "white supremacist language":

                                          ## On ideologically motivated changes

                                          This is a purely technical project. As such, it is not an appropriate arena to advertise your personal politics or religious beliefs. Any changes that appear ideologically motivated will be rejected.

                                          Someone changing "he" to "they" in a comment as their only change could absolutely be seen as "politically motivated." My understanding is that if changing the comment was part of some larger useful change, it would be fine (as would using "she" or "they" in a new comment), but just changing the gender of a pronoun in a comment is a useless change.

                                          If the comment said "she," would someone have been motivated to make this change? Probably not. Should changing this from "she" to some other pronoun (he or they) also be rejected? Yes, on the same grounds as changing it from "he," it's not a useful change and just wastes everyone's time. If you're in the code already, then go ahead, correct silly language like this if you care to.

                                          E This user is from outside of this forum
                                          E This user is from outside of this forum
                                          [email protected]
                                          wrote on last edited by
                                          #103

                                          Inclusive pronouns are not political, full stop.

                                          S S 2 Replies Last reply
                                          0
                                          Reply
                                          • Reply as topic
                                          Log in to reply
                                          • Oldest to Newest
                                          • Newest to Oldest
                                          • Most Votes


                                          • Login

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular
                                          • World
                                          • Users
                                          • Groups