True crime
-
This post did not contain any content.
-
This post did not contain any content.
What the fuck
-
This post did not contain any content.
I mean aside of the variable name, this is not entirely unreasonable.
-
This post did not contain any content.
i would say why would you just not to
isAdmin = truebut i also worked with someone who did just this so i'll instead just sigh.also the real crime is the use of javascript tbh
-
This post did not contain any content.
What if
roleisFILE_NOT_FOUND?! -
i would say why would you just not to
isAdmin = truebut i also worked with someone who did just this so i'll instead just sigh.also the real crime is the use of javascript tbh
That's TypeScript. I can tell by the pixels defining a type above.
-
This post did not contain any content.wrote last edited by [email protected]
role is never instantiated, so the... privileged....logs.... will never be called
Edit: Actually no logs at all, I read the null as undefined on first skim
-
This post did not contain any content.
This is pretty clearly just rage bait. Nothing is actually setting the value so it's undef. Moreover there isn't any context here to suggest if the state definitions are determined by some weird api or are actually just made up
-
This post did not contain any content.
Ah, the ol' tristate boolean switcheroo
-
What if
roleisFILE_NOT_FOUND?!if it's
'FILE_NOT_FOUND'then the string will be read as truthy and you will get'User is admin'logged. -
if it's
'FILE_NOT_FOUND'then the string will be read as truthy and you will get'User is admin'logged.Ackshually three equal signs check for type as well. So mere truthiness is not enough. It has to be exactly true.
Also, everyone knows FILE_NOT_FOUND isn't a string but a boolean value.
-
This is pretty clearly just rage bait. Nothing is actually setting the value so it's undef. Moreover there isn't any context here to suggest if the state definitions are determined by some weird api or are actually just made up
wrote last edited by [email protected]Troof
I mean facts. Facts is what the kids say. Facts.
-
I mean aside of the variable name, this is not entirely unreasonable.
wrote last edited by [email protected]E: omg forget my whole comment. I agree with you that the name sucks.
I mostly don't like that
roleis typically an intuitive name, and now suddenly it means something I wouldn't expect. Why add confusion to your code? I don't always remember what I meant week to week, much less if someone else wrote it. -
E: omg forget my whole comment. I agree with you that the name sucks.
I mostly don't like that
roleis typically an intuitive name, and now suddenly it means something I wouldn't expect. Why add confusion to your code? I don't always remember what I meant week to week, much less if someone else wrote it.If I had a nickel for every time that happened to me, I’d still be poor, but at least I’d have several nickels.
-
That's TypeScript. I can tell by the pixels defining a type above.
Was looking at it and could not figure out why their weren't any semicolon's.
-
I mean aside of the variable name, this is not entirely unreasonable.
I would certainly rather see this than
{isAdmin: bool; isLoggedIn: bool}. Withboolean | null, at least illegal states are unrepresentable... even if the legal states are represented in an... interesting way. -
Was looking at it and could not figure out why their weren't any semicolon's.
Neither Javascript nor Typescript require semicolon, it is entirely a stylistic choice except in very rare circumstances that do not come up in normal code.
-
This post did not contain any content.
Sadly this is (or used to be) valid in PHP and it made for some debugging “fun”.
-
Neither Javascript nor Typescript require semicolon, it is entirely a stylistic choice except in very rare circumstances that do not come up in normal code.
That's good to know. Don't know how I didn't know this. Been writing JS since 2000. Always just used them I guess. Ecmascripts look funny to me without them
-
Sadly this is (or used to be) valid in PHP and it made for some debugging “fun”.
There are several small details that PHP won't allow, but It's valid Javascript and it's the kind of thing you may find on that language.
